Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: use python virtual environment before running pip #827

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Oct 9, 2024

What it solves

Resolves #826

How this PR fixes it

Newer ubuntu versions enforce PEP-668 which prevents installing python packages without a virtual environment so we create and activate one before calling pip

@usame-algan usame-algan changed the title chore: uses apt-get instead of pip install chore: use apt-get instead of pip install Oct 9, 2024
@usame-algan usame-algan force-pushed the fix-deploy-workflow branch 3 times, most recently from 3a0a1a9 to 58cfee0 Compare October 9, 2024 11:52
@usame-algan usame-algan changed the title chore: use apt-get instead of pip install chore: use python virtual environment before running pip Oct 9, 2024
@usame-algan usame-algan marked this pull request as ready for review October 9, 2024 11:58
@usame-algan usame-algan merged commit 310429d into development Oct 9, 2024
8 of 9 checks passed
@usame-algan usame-algan deleted the fix-deploy-workflow branch October 9, 2024 21:35
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github deployment workflow fails with ubuntu-latest
2 participants