Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: add Base stablecoins for swaps #4678

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Fix: add Base stablecoins for swaps #4678

merged 1 commit into from
Dec 18, 2024

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Dec 17, 2024

What it solves

Resolves #4649.

Top stable coins on Base, data from https://basescan.org/tokens

@katspaugh katspaugh marked this pull request as ready for review December 17, 2024 10:39
Copy link

github-actions bot commented Dec 17, 2024

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1016.48 KB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 73.91% 14399/19483
🔴 Branches 51.44% 3437/6681
🔴 Functions 56.86% 2044/3595
🟡 Lines 75.44% 13059/17311

Test suite run success

1712 tests passing in 232 suites.

Report generated by 🧪jest coverage report action from a21884a

@francovenica
Copy link
Contributor

Looks good:
image

@katspaugh katspaugh merged commit 918b913 into dev Dec 18, 2024
16 checks passed
@katspaugh katspaugh deleted the stables branch December 18, 2024 08:01
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swap in Base - Set the fee to .1% for stable coins
3 participants