Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove imports from sage.interfaces.all #33007

Closed
mkoeppe opened this issue Dec 10, 2021 · 13 comments
Closed

Remove imports from sage.interfaces.all #33007

mkoeppe opened this issue Dec 10, 2021 · 13 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 10, 2021

Depends on #32989

CC: @fchapoton

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 584d121

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/33007

@mkoeppe mkoeppe added this to the sage-9.5 milestone Dec 10, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 10, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 10, 2021

Commit: 607316f

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 10, 2021

New commits:

a9b7517git grep -l 'interfaces.all import' | xargs sed -E -i.bak 's/interfaces[.]all import ([a-z][a-z]*)/interfaces.\1 import \1/'
607316fRemove remaining imports from sage.interfaces.all

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 10, 2021

Author: Matthias Koeppe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 21, 2021

Changed commit from 607316f to 0e814dc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 21, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

2d9a84egit grep -l 'misc.all import' | xargs sed -i.bak 's/misc.all import tmp_/misc.temporary_file import tmp_/'
5a8d76eRemove imports from sage.misc.all
97b4dfdgit grep -l 'misc.all import' | xargs sed -i.bak 's/misc.all import sage_eval/misc.sage_eval import sage_eval/'
e72dc8eRemove more imports from sage.misc.all
d114096git grep -l 'misc.all import' | xargs sed -i.bak 's/misc.all import cartesian_product_iterator/misc.mrange import cartesian_product_iterator/'
1ab9441Remove remaining imports from sage.misc.all
0e814dcMerge #32989

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 21, 2021

Dependencies: #32989

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 21, 2021
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 29, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

37789fdMerge tag '9.5.beta9' into t/33007/remove_imports_from_sage_interfaces_all
584d121src/sage/rings/polynomial/multi_polynomial_libsingular.pyx: Fix import

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 29, 2021

Changed commit from 0e814dc to 584d121

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:8

ok, ok

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 11, 2022

comment:9

Thanks.

@vbraun
Copy link
Member

vbraun commented Feb 12, 2022

Changed branch from u/mkoeppe/remove_imports_from_sage_interfaces_all to 584d121

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants