Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

more care about parameter immutable in sage/graphs/generic_graph.py #39297

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

dcoudert
Copy link
Contributor

@dcoudert dcoudert commented Jan 7, 2025

Following #39280, #39285, #39287, #39296 and discussions in #39177, we add parameter immutable to methods in sage/graphs/generic_graph.py:

  • longest_cycle
  • longest_path
  • hamiltonian_path
  • and add tests in cycle_basis

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@dcoudert dcoudert self-assigned this Jan 7, 2025
@dcoudert dcoudert changed the title more care about parameter immutable in generic_graph.py more care about parameter immutable in sage/graphs/generic_graph.py Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Documentation preview for this PR (built with commit 6dc4315; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kwankyu
Copy link
Collaborator

kwankyu commented Feb 10, 2025

Namewise, mutable=True (default) would have been a better choice. But I also believe immutable was chosen after all things considered by experts.

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit ef384b4 into sagemath:develop Feb 10, 2025
21 of 23 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants