-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Fix Build] Don't care about icon scaling #409
Conversation
SFOS 4.5 introduces z2.5, lets just include any scale
As it is purely a build fix not sure this warrants a new tag/release, might as well tag it as a '+git1' version and allow OBS to build. Therefore I did a 3.2.6-fixes branch based on tag 3.2.6, cherry-picked this, and have taken the liberty to point |
@Olf0 if you agree with this, please submit that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine.
actually I am keen on making a new release, because I committed fixes to the CI run triggered by setting a new tag since the last release and would like to test that in "real life" (although I assume it is fine now). So if you have anything else to add to an Patchmanager 3.2.7 release, please pose another PR. If not, please tell me that. Cheers! |
Fine from my PoV. I have nothing important queued at the moment.
Thanks!
|
Just one of my checks&balances questions: The icon for Edit: The build error at the SFOS-OBS answers that:
Hence releasing Patchmanager 3.2.7. |
Yes, that |
SFOS 4.5 introduces z2.5, lets just include any scale
Fixes building on OBS