This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
Fix views crashing when description or content fields are null #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
quick-fix-nullable-content-description-fields
github-actions
bot
temporarily deployed
to
storybook quick-fix-nullable-content-description-fields
orzechdev
reviewed
Feb 23, 2021
src/views/Article/View.tsx
Outdated
| @@ -13,8 +13,8 @@ import { TypedArticleQuery } from "./query"; | |||
|
|
|||
| import "./scss/index.scss"; | |||
|
|
|||
| const canDisplay = page => | |||
| maybe(() => !!page && !!page.title && !!page.content); | |||
| const canDisplay = page => maybe(() => !!page && !!page.title); | |||
There was a problem hiding this comment.
maybe? 👮
Suggested change
| const canDisplay = page => maybe(() => !!page && !!page.title); | |
| const canDisplay = page => !!page?.title; |
src/views/Product/View.tsx
Outdated
| !!product.# && | ||
| !!product.variants | ||
| ); | ||
| maybe(() => !!product.name && !!product.# && !!product.variants); |
github-actions
bot
temporarily deployed
to
quick-fix-nullable-content-description-fields
maarcingebala
approved these changes
Feb 23, 2021
orzechdev
approved these changes
Feb 23, 2021
maarcingebala
deleted the
quick-fix-nullable-content-description-fields
branch
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because it fixes pages / product details crashing when content or description fields are null
Screenshots
Pull Request Checklist
Test Environment Config
API_URI=https://master.staging.saleor.cloud/graphql/