Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Create an ECJ version of StrictJavaDepsPlugin #6

Closed
guw opened this issue Mar 24, 2022 · 1 comment
Closed

Create an ECJ version of StrictJavaDepsPlugin #6

guw opened this issue Mar 24, 2022 · 1 comment

Comments

@guw
Copy link
Contributor

guw commented Mar 24, 2022

Once #5 is available we need to create a plug-in that implements StrictJavaDepsPlugin based on the ECJ AST.

/**
 * A plugin for BlazeJavaCompiler that checks for types referenced directly in the source, but
 * included through transitive dependencies. To get this information, we hook into the type
 * attribution phase of the BlazeJavaCompiler (thus the overhead is another tree scan with the
 * classic visitor). The constructor takes a map from jar names to target names, only for the jars
 * that come from transitive dependencies (Blaze computes this information).
 */
public final class StrictJavaDepsPlugin extends BlazeJavaCompilerPlugin {..}

There might be a more efficient way to do this in ECJ without the need of #5.

@guw
Copy link
Contributor Author

guw commented Aug 11, 2023

Fixed with #15 by configuring access rules and collecting dependency information separately

@guw guw closed this as completed Aug 11, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant