Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[SSR] Superclasses cannot have constructor arguments #5080

Closed
nolanlawson opened this issue Dec 20, 2024 · 1 comment · Fixed by #5094
Closed

[SSR] Superclasses cannot have constructor arguments #5080

nolanlawson opened this issue Dec 20, 2024 · 1 comment · Fixed by #5094
Labels
BUG P3 bug SSR

Comments

@nolanlawson
Copy link
Contributor

nolanlawson commented Dec 20, 2024 •
edited
Loading

If you have a superclass with arguments in its constructor, and if the subclass tries to pass in those arguments via super, then this currently fails in the SSR compiler. The reason is that the SSR compiler overwrites the constructor's args with its own propsAvailableAtConstruction object.

See #5076
@git2gus Git2Gus
Copy link

git2gus bot commented Dec 20, 2024

This issue has been linked to a new work item: W-17486503

nolanlawson added a commit that referenced this issue Jan 3, 2025
@nolanlawson
fix(ssr): fix constructor with args
28bac1c 
Fixes #5080
@nolanlawson nolanlawson mentioned this issue Jan 3, 2025
Merged
nolanlawson added a commit that referenced this issue Jan 6, 2025
@nolanlawson
fix(ssr): fix constructor with args (#5094)
e4b3c46 
Fixes #5080
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
BUG P3 bug SSR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ssr): fix constructor with args salesforce/lwc
1 participant
@nolanlawson