Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test(engine-server): more slot tests #4666

Merged
merged 1 commit into from
Oct 21, 2024
Merged

test(engine-server): more slot tests #4666

merged 1 commit into from
Oct 21, 2024

Conversation

nolanlawson
Copy link
Contributor

Details

We don't have enough tests for slots. This adds tests for:

  • duplicate slots (both in the template and in the consumer)
  • slot reordering (between the template and the consumer)
  • nonexistent slot names (not defined in the template)

We should probably add a test for light DOM slot forwarding as well at some point.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

@nolanlawson nolanlawson requested a review from a team as a code owner October 18, 2024 21:02
@nolanlawson nolanlawson merged commit 02e434e into master Oct 21, 2024
11 checks passed
@nolanlawson nolanlawson deleted the nolan/slots-ssr branch October 21, 2024 15:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ekashida ekashida ekashida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nolanlawson @ekashida