fix(integration-karma): run hydration preprocessor just for focused tests #4673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cardoso
changed the title
nolanlawson
requested changes
Oct 21, 2024
packages/@lwc/integration-karma/scripts/karma-configs/hydration/base.js
Outdated
Show resolved
Hide resolved
packages/@lwc/integration-karma/scripts/karma-configs/hydration/base.js
Outdated
Show resolved
Hide resolved
cardoso
force-pushed
the
hydration-tests-only
branch
from
ff81783 to
000cf78
Compare
cardoso
changed the title
cardoso
changed the title
nolanlawson
approved these changes
Oct 21, 2024
|
Thanks! |
|
/nucleus test |
|
Somehow this merged via GitHub auto-merge despite failing the I'll have to fix our CI settings, but I'll open up another PR to fix the glob issue... |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
I found it a bit difficult to debug the server-side code when using the .only as the transformation will run for all tests.
I added this quick solution to run the transformation just for the focused tests (probably can be improved).
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item