fix(ssr-compiler): namespace & name are optional in CompilerTransformOptions #5058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cardoso
commented
Dec 18, 2024
Comment on lines
-36
to
+37
| const isFunctionOrClass = (node: any) => | ||
| const isFunctionOrClass = (node: any): node is FunctionDeclaration | ClassDeclaration => |
There was a problem hiding this comment.
This is an error if you're using the workspace version of typescript (5.4.5). Type predicates are only inferred in 5.5 🥲 so close.
nolanlawson
approved these changes
Dec 18, 2024
|
/nucleus test |
wjhsf
added a commit
that referenced
this pull request
Dec 20, 2024
* test(ssr): add tests for nested elements in slots (#5048) * fix(compiler): log warning for missing name/namespace (#4825) * test(karma): remove unnecessary IE11-related code (#5054) * fix: replace barrel exports from `lwc` with `@lwc/ssr-runtime` (#5034) * fix: replace barrel from `lwc` package with '@lwc/ssr-runtime' * fix: handle * barrel case and corresponding tests * fix: function naming * fix: barrel import test parity * fix: include optional exported alias for export all declaration replacement, tests * chore: explain function name massaging in test * fix: deep clone objects and optimize tests * fix: remove unused shared file * test(karma): add test for for:each issue #4889 (#5053) * fix(ssr): missing bookends for slotted lwc:if not at the top-level (#5027) Co-authored-by: Nolan Lawson <nolan@nolanlawson.com> * fix(ssr): fix HTML comment bookends for if blocks (#5055) Co-authored-by: Will Harney <wharney@salesforce.com> * fix(ssr-compiler): namespace and name should be optional in ComponentTransformOptions (#5058) * test(ssr): test `if` with adjacent text (#5056) * test(karma): reduce #4889 even further (#5060) * fix(ssr): fix `style` attribute rendering (#5061) * fix(ssr-compiler): harmonize some wire errors (#5062) Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> * fix: only call callback when needed @W-17420330 (#5064) * fix: only call callback when needed @W-17420330 * chore: simplify test * fix: use correct class check * fix(ssr): render from superclass (#5063) Co-authored-by: Nolan Lawson <nlawson@salesforce.com> * test(ssr): add more superclass tests (#5065) * fix: use correct shadow root @W-17441501 (#5070) * fix: use correct shadow root @W-17441501 * chore: yagni i guess * chore: 🛩️📦 * If you read this, tell me so! * fix(ssr): align csr and ssr reflective behavior (#5050) * chore: release v8.12.2 @W-17485572 (#5075) --------- Co-authored-by: Nolan Lawson <nlawson@salesforce.com> Co-authored-by: jhefferman-sfdc <83669775+jhefferman-sfdc@users.noreply.github.com> Co-authored-by: Matheus Cardoso <matheus@cardo.so> Co-authored-by: Nolan Lawson <nolan@nolanlawson.com> Co-authored-by: Eugene Kashida <ekashida@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This is a type-only fix.
It was probably an unintended change introduced in #5033 which caused some type errors in tests:
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item