Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(signals): avoid throwing when in check throws [backport] #5110

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

nolanlawson
Copy link
Contributor

Details

Same as #5105 but backport.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

@nolanlawson nolanlawson requested a review from a team as a code owner January 8, 2025 18:46
@nolanlawson nolanlawson changed the base branch from master to spring25 January 8, 2025 18:47
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
@nolanlawson nolanlawson force-pushed the nolan/fix-signals-backport branch from 3cff847 to da7bd07 Compare January 8, 2025 18:47
@nolanlawson nolanlawson changed the title fix(signals): avoid throwing when in check throws (#5105) fix(signals): avoid throwing when in check throws [backport] Jan 8, 2025
Copy link
Contributor

❌ One or More Pre-release Checks Failed

  • Check PR user has rights to execute the workflow
    PR owner is allowed to initiate release/deploy

  • Check PR is approved
    PR 5110 is approved

  • Check PR is mergeable
    PR 5110 is mergeable

  • ⚠️ Check GUS reference is present
    PR does not contain a reference to a GUS work item. You can update it any time by including '@W-XXXXXXX' into the title or body of the PR

  • Check no conflicting Github release
    A Github release already exists with a tag of v8.10.1. Please commit/push a version bump to the nolan/fix-signals-backport branch or have Nucleus do it for you by responding with the following comment
    /nucleus bump-version [version]

    To skip this check, run /nucleus release --force

  • Check NPM packages have not been released yet
    Version 8.10.1 of this project has already been published. If you would like to skip NPM publishing, then run /nucleus release --skipNpmRelease.If you want to bump the version in your source branch, run /nucleus bump-version [version]

  • ⚪️ Check Maven artifacts have not been released yet (skipped)
    Skipping check since project doesn't deliver Maven artifacts

  • ⚪️ Check GAV mapping exists for jar repo (skipped)
    Skipping GAV mapping check because a core jar is not being released.

@nolanlawson nolanlawson merged commit a2c74f2 into spring25 Jan 8, 2025
11 of 12 checks passed
@nolanlawson nolanlawson deleted the nolan/fix-signals-backport branch January 8, 2025 20:10
Copy link
Contributor

❌ One or More Pre-release Checks Failed

  • ⚪️ Check PR user has rights to execute the workflow (skipped)
    Skipping PR owner check since PR has already been merged.

  • Check PR is approved
    PR 5110 is approved

  • ⚪️ Check PR is mergeable (skipped)
    PR 5110 has already been merged

  • ⚠️ Check GUS reference is present
    PR does not contain a reference to a GUS work item. You can update it any time by including '@W-XXXXXXX' into the title or body of the PR

  • Check no conflicting Github release
    A Github release already exists with a tag of v8.10.1. Please commit/push a version bump to the nolan/fix-signals-backport branch or have Nucleus do it for you by responding with the following comment
    /nucleus bump-version [version]

    To skip this check, run /nucleus release --force

  • Check NPM packages have not been released yet
    Version 8.10.1 of this project has already been published. If you would like to skip NPM publishing, then run /nucleus release --skipNpmRelease.If you want to bump the version in your source branch, run /nucleus bump-version [version]

  • ⚪️ Check Maven artifacts have not been released yet (skipped)
    Skipping check since project doesn't deliver Maven artifacts

  • ⚪️ Check GAV mapping exists for jar repo (skipped)
    Skipping GAV mapping check because a core jar is not being released.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants