Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

isolated modules and almost isolated declarations #486

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Jan 9, 2025

isolatedModules and isolatedDeclarations provide guardrails that help make type checking faster / more portable. We don't actually need the flags enabled for our current build process / target, but it makes the code more portable if we decide to make changes in the future. And the code changes are pretty trivial, so I figured why not.

Note that we can't actually enable the isolatedDeclarations flag because we use a symbol as a property key, but I've made all the other changes to be 99% compatible.

[Symbol.for('nodejs.util.inspect.custom')](): string {

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant