-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add support for errorfiles in listen and backend blocks and more global ssl settings #80
base: master
Are you sure you want to change the base?
Conversation
@darix can you also update the pillar.example with an example? |
it is basically the same as in defaults just copied into the respective
sections. does that really need a copy?
|
@darix no need to copy, just make a reference so they know they can use it there as well |
efa90ce
to
53ab2f1
Compare
done |
6d5380c
to
33f4d7e
Compare
@daks will you please take a look? |
JFYI: working on the next feature already. But this is still untested: this ugly code is needed because salt mine doesnt work within a pillar sls file. need to learn how to do a helper within a formular. so i can remove all the code duplication between listens and backends. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@darix Looks good to me. Your commit messages needs some changes though, please look at https://github.com/saltstack-formulas/template-formula/tree/master/docs#contributing-to-this-repo
It would have been great to test those features in Inspec but at the moment those tests are already minimal...
update: I tested debian-11/10/9 on 3004-py3 and all fine 👍
what are you trying to do with this code? Retrieving items via salt mine? If it's the case, and you need inspiration, you can look at how openssh-formula or mysql-formula do it, see https://github.com/saltstack-formulas/openssh-formula/blob/master/openssh/files/default/ssh_known_hosts https://github.com/saltstack-formulas/mysql-formula/blob/master/mysql/user.sls. (those are just examples and may not correspond to your particular need) |
I have the salt mine stuff implemented now. I was wondering actually if I could just merge it into this PR or if you want a separate one. Full diff darix/haproxy-formula@master...add_salt_mine_support |
I think a separate PR is better |
No description provided.