Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add --sys-info-and-exit CLI flag support. #174

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

s0undt3ch
Copy link
Contributor

Basically prints the system information and exits. Doesn't run any tests.

Fixes #173

@s0undt3ch s0undt3ch requested a review from a team as a code owner January 23, 2024 08:01
@s0undt3ch s0undt3ch requested review from twangboy and removed request for a team January 23, 2024 08:01
@s0undt3ch s0undt3ch self-assigned this Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (16a15c9) 85.28% compared to head (d33a477) 85.22%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   85.28%   85.22%   -0.05%     
==========================================
  Files          97       97              
  Lines        5942     5960      +18     
  Branches      631      633       +2     
==========================================
+ Hits         5067     5079      +12     
- Misses        702      706       +4     
- Partials      173      175       +2     
Flag Coverage Δ
Linux 84.80% <100.00%> (+0.05%) ⬆️
Windows 76.50% <100.00%> (+0.08%) ⬆️
macOS ?
py3.10 84.87% <100.00%> (-0.02%) ⬇️
py3.7 84.10% <100.00%> (+0.05%) ⬆️
py3.8 84.94% <100.00%> (+0.05%) ⬆️
py3.9 84.96% <100.00%> (-0.02%) ⬇️
pytest-7.3.0 84.94% <100.00%> (-0.02%) ⬇️
pytest-7.4.0 84.94% <100.00%> (-0.02%) ⬇️
pytest-8.0.0rc2 84.25% <100.00%> (?)
salt-3005.0 84.79% <100.00%> (+0.05%) ⬆️
salt-3006.0 84.92% <100.00%> (-0.02%) ⬇️
src 77.21% <100.00%> (+0.05%) ⬆️
tests 96.28% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/saltfactories/plugins/sysinfo.py 100.00% <100.00%> (ø)
tests/functional/test_sys_info.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Basically prints the system information and exits. Doesn't run any tests.

Fixes saltstack#173

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch s0undt3ch force-pushed the master branch 2 times, most recently from 73ad2ae to b57b208 Compare January 23, 2024 09:36
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch s0undt3ch merged commit e16a98a into saltstack:master Jan 23, 2024
1 of 2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a --sys-info-and-exit flag for CI usage
1 participant