Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixes 67250 #67253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes 67250 #67253

wants to merge 1 commit into from

Conversation

stupiddr
Copy link

@stupiddr stupiddr commented Feb 3, 2025

What does this PR do?

Fixes issues with mine.get and mine.update when using the Redis cache backend

What issues does this PR fix or reference?

#67250

Previous Behavior

salt mine.get does not work using the redis cache with compound or grain targets and mine.update saves data to the redis cache incorrectly

New Behavior

salt mine.get works using the redis cache with compound or grain targets and mine.update saves data correctly

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@stupiddr stupiddr requested a review from a team as a code owner February 3, 2025 22:02
Copy link

welcome bot commented Feb 3, 2025

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@dwoz
Copy link
Contributor

dwoz commented Feb 3, 2025

@stupiddr

This PR is a bugfix and should be opened against 3006.x. We also kindly ask that you add a regression test and changelog entry.

@bdrx312
Copy link
Contributor

bdrx312 commented Feb 7, 2025

Also this and #67125 appear to be duplicates.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants