Return empty string for empty buffer #42

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Open

owahltinez wants to merge 1 commit into samcday:main from owahltinez:patch-1

owahltinez commented Aug 30, 2018

When calling getContentsAsString(), function should always return a string type. If the buffer is empty, return value should be an empty string. This matches the type definitions at https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/stream-buffers/index.d.ts


          Return empty string for empty buffer

8c006cd

Change return short-circuit from `false` to empty string or empty buffer.
When calling getContentsAsString(), function should always return a string type. If the buffer is empty, return value should be an empty string. This matches the type definitions at https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/stream-buffers/index.d.ts

owahltinez force-pushed the patch-1 branch from 4840a45 to 8c006cd Compare

August 31, 2018 07:25

shisama mentioned this pull request

refactor(plugin-packer): Migrate to TypeScript kintone/js-sdk#671

Merged

6 tasks

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet