Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

missing esm module build #134

Merged
merged 2 commits into from
Feb 16, 2025
Merged

missing esm module build #134

merged 2 commits into from
Feb 16, 2025

Conversation

ryoppippi
Copy link
Contributor

@ryoppippi ryoppippi commented Feb 9, 2025

This pull request includes updates to the build configuration and dependencies to improve the build process.

This needs esm build for typia

Dependency updates:

  • Added tinyglobby version ^0.2.10 to the package.json file.

Build configuration updates:

  • Modified rollup.config.js to use tinyglobby for input file globbing instead of a single entry point.

Adds rollup-plugin-auto-external to automatically exclude dependencies and
peerDependencies from the bundle to reduce bundle size and improve build
performance.
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/rollup-plugin-auto-external@2.0.0 Transitive: environment, filesystem +27 576 kB stevenbenisek
npm/tinyglobby@0.2.10 Transitive: filesystem +2 155 kB superchupu

View full report↗︎

@ryoppippi
Copy link
Contributor Author

It's not critical so just check it out @samchon

@ryoppippi
Copy link
Contributor Author

Also I think it's a better idea to show the esm transformation in this project first because it is way smaller than typia

@samchon samchon changed the base branch from master to v3.0-esm February 16, 2025 18:39
Copy link
Owner

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test it.

And even though NodeJS deprecates CJS in the latest version, it would take a lot of time that the new NodeJS version in the industry. I'll move to ESM when TypeScript and NestJS accept it.

@samchon samchon merged commit 81dbbc0 into samchon:v3.0-esm Feb 16, 2025
4 checks passed
@ryoppippi ryoppippi deleted the feature/esm branch February 16, 2025 18:41
@samchon
Copy link
Owner

samchon commented Feb 16, 2025

Will publish at v3.0 update, and it would be when TS 5.8 released.

Thanks for contribution.

@samchon
Copy link
Owner

samchon commented Feb 16, 2025

The main reason of bundling to multiple mjs files are, it is efficient for single bundled mjs file in the web environment, right?

@ryoppippi
Copy link
Contributor Author

@samchon Yes exactly.
Also in the previous config, you only build index.ts to mjs format

@ryoppippi
Copy link
Contributor Author

ryoppippi commented Feb 20, 2025

When I'm working on esm full build for typia, I found that some modules in @samchon/openapi are not built for esm.
So that's why I contribute this .

If I release it, I can start working for typia. Submoudles (eg, lib/internal/foo) is not built as esm format as well

samchon added a commit that referenced this pull request Mar 1, 2025
* Add `IJsonSchemaAttribute`. (#135)

* Add `IJsonSchemaAttribute`.

* Publish as v2.5

* Enhance IJsonSchemaAttribute type with nested items. (#136)

* Add `IJsonSchemaAttribute`.

* Publish as v2.5

* Enhance `IJsonSchemaAttribute` type with nested items.

* Change rule of the `IHttpMigrateRoute.emendedPath` (#137)

* Add `IJsonSchemaAttribute`.

* Publish as v2.5

* Enhance `IJsonSchemaAttribute` type with nested items.

* Change rule of the `IHTtpMigrateRoute.emendedPath`

* Test whether `IHttpLlmApplication` covers ILlmApplication (#138)

* Add `IJsonSchemaAttribute`.

* Publish as v2.5

* Enhance `IJsonSchemaAttribute` type with nested items.

* Change rule of the `IHTtpMigrateRoute.emendedPath`

* Test whether `IHttpLlmApplication` covers `ILlmApplication`

* missing esm module build (#134)

* feat: build all module in esm

* feat: add rollup-plugin-auto-external

Adds rollup-plugin-auto-external to automatically exclude dependencies and
peerDependencies from the bundle to reduce bundle size and improve build
performance.

* New embedded function `IHttpLlmFunction.validate()`for validation feedback (#147)

* Developing internal validator

* Prepared testing program

* Only object discriminator is left

* Fiix HTTP application accessors

* Validator implementation completed

* Publish v3

---------

Co-authored-by: ryoppippi <1560508+ryoppippi@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants