Rework #5
Rework #5
Conversation
- rename I2s to I2sDriver and Instance to I2sPeripheral to avoid confusion with mcu hal. - delete many thing. it will be reimplemented differently
almost nothing remain from v0.2
|
Ready for a review, sorry for the big chunk of commits, as i said, i was working on another branch. I didn't (yet) fix previously mentioned problems, i just documented them |
|
I'm glad to see that this is ready. In about 7 days, I'll have enough time to fully review it. |
|
I already found a issue with "transfer", i have a channel inversion when i'm using "master transmit" + "slave receive". I don't know what's wrong. |
|
Now that I've had some time to look more, this looks like a great set of changes. I'm ready to merge this whenever you think it's ready. |
|
unfortunately not ready. Since I found the "channel inversion" issue, i realized my test wasn't rigorous enough. I was just testing with my pcm* ADC and DAC devices but having sound does mean everything is right. So I started a project dedicated to test. The main idea is to use 2 I2s perpipheral, write few data with the first and read those data with the second. This makes me discover another issue. |
|
Errors fixed ! I did a project dedicated to test to find them |
|
Released as 0.3.0 |
Hi, since a while, i'm working on a full rewrite of this crate. It's because i've found many issue making it too easy to use it incorrectly and difficult to use correctly.
This is still a work in progress, for example i plan to "type state" more the system to prevent doing meanless things like reading data register while being in transmit mode, but i didn't yet determined what extactly to put in the "type state" system.
I'm currently trying to validate a proof of concept by using it on stm32f4xx-hal and implementing an example using a master and a slave through interruption.