Rails version pin, spec_helper fixes #207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… null virus scanner, and clean repository vbefore suite.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two unrelated minor changes:
hyrax-3branch a modification tospec/spec_helper.rbthat invokesActiveFedora::Cleaner.clean!(once) before suite execution. This helps in certain cases with dirty repository state, which can aide corner-cases where local testing breaks.Note: included in the spec_helper.rb changes, there is an incidental and totally harmless monkey-patch for a Hyrax 3 patch — it will not have any side-effects in Hyrax 2, and cherry-picking that commit can help avoid future merge conflicts.