FileSets and Works should barf clearly when a Collection is added as a member #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjgiarlo
force-pushed
the
clarify_error_message_259
branch
from
e1e0659 to
ce23148
Compare
|
This solution feels a bit heavy for what it's doing, which is spitting out a clearer error message that is supplied by Hydra::PCDM: https://github.com/projecthydra-labs/hydra-pcdm/blob/master/lib/hydra/pcdm/validators/pcdm_object_validator.rb#L2-L8 On the other hand, it follows the patterns established in the Thoughts, @jcoyne @tpendragon @escowles @elrayle ? |
|
Not pretty, but it works, and I don't know a better solution. Sooo...:+1: |
escowles
added a commit
that referenced
this pull request
Mar 4, 2016
FileSets and Works should barf clearly when a Collection is added as a member
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #259