Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

352 remove om #354

Merged
merged 2 commits into from
Sep 21, 2018
Merged

352 remove om #354

merged 2 commits into from
Sep 21, 2018

Conversation

barmintor
Copy link
Member

If the public API is understood to be the CharacterizationService, this is a non-breaking change.

If the Om-based parser was accessed via its proxy terms (as the CharacterizationService does), this is a non-breaking change.

@mark-dce mark-dce mentioned this pull request Sep 20, 2018
Closed
mark-dce
mark-dce approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@mark-dce mark-dce left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @barmintor

@mark-dce mark-dce merged commit a8b4e0b into master Sep 21, 2018
@mark-dce mark-dce deleted the 352-removeOm branch September 21, 2018 15:02
@mark-dce mark-dce mentioned this pull request Sep 21, 2018
Closed
@jrgriffiniii jrgriffiniii mentioned this pull request Aug 2, 2019
Open
@jrgriffiniii jrgriffiniii mentioned this pull request Aug 16, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mark-dce mark-dce mark-dce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barmintor @mark-dce