[wings] Inline #query, #post, and #get into solr_service from AF #3834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackartisan
force-pushed
the
3800-solr-service
branch
from
16c6183 to
2ad6778
Compare
no-reply
reviewed
Jun 20, 2019
app/models/solr_hit.rb
Outdated
| @@ -0,0 +1,29 @@ | |||
| class SolrHit < Delegator | |||
| def self.for(hit) | |||
| return hit if hit.is_a? ActiveFedora::SolrHit | |||
There was a problem hiding this comment.
should this be just SolrHit?
hackartisan
force-pushed
the
3800-solr-service
branch
from
2ad6778 to
eec048e
Compare
no-reply
approved these changes
Jun 20, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #3800
This is a small step toward having a full solr indexing and query service directly in hyrax. It sets us up to start working on bringing the connection itself into hyrax and testing an approach to a samvera/valkyrie#598