Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow removal of Location fields, and related QOL fixes #6720

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

bbpennel
Copy link
Contributor

Fixes

#6719

Summary

Fixes issue with the Location field (as described in 6719), that prevents removal of the first location field. Fixes a few other issues and gets the display a little more consistent.

Work was done by @davidcam-src

Guidance for testing, such as acceptance criteria or new user interface behaviors:

See the linked ticket. It's helpful to add and remove locations at the same time for both new and existing works, and then verifying the expected locations show up on the work.

To test in Dassie, you'll need to update the .dassie/.env file to add a GEONAMES_USERNAME= entry with a valid geonames username.

Type of change (for release notes)

notes-bugfix

Detailed Description

Resolves an additional issue when creating a new work, where adding and then removing a location will result in the removed location appearing on the created work.

Adds in placeholder text for inputs after the first one (with the same placeholder text as the first input)

Some additional complications arose when deleting entries on existing works due to index collisions between delete and newly added entries.

Changes proposed in this pull request:

  • Updates to javascript to get the Remove button to appear all the time and work with all location entries

@samvera/hyrax-code-reviewers

…terms now, and should correctly allow for values to be removed on new and existing works. Adds placeholder text to location inputs after the first one.
Copy link
Member

@orangewolf orangewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jeremyf jeremyf merged commit 2b3854f into main Mar 11, 2024
6 checks passed
@jeremyf jeremyf deleted the hyrax-6719-location branch March 11, 2024 14:33
jeremyf added a commit that referenced this pull request Mar 20, 2024
* main:
  🐛 Use configured class instead of hard-coded (#6717)
  Remove button should always appear next to location/controlled vocab terms now, and should correctly allow for values to be removed on new and existing works. Adds placeholder text to location inputs after the first one. (#6720)
  ♻️ Ensure setting permission template for work factories (#6723)
  Use compact, not flatten, in the model registry (#6737)
@dlpierce dlpierce added the notes-bugfix Release Notes: Fixed a bug label Mar 29, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
notes-bugfix Release Notes: Fixed a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants