-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chart: add support for startupProbe #6741
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great.
no idea why CI is failing, but it's clearly not related
yeah, weird
|
maybe a CI cache issue? |
I wonder if this is caused by the slash in the branch name on Circle ( |
oh that could be; why would that suddenly be a problem, though? |
See https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-startup-probes This enables apps with long startups to not be killed prematurely.
@dunn can you resubmit this as a PR from i think this isn't suddenly an issue, but a general issue with PRs from forks (which i actually think it's reasonable for our build pipelines to reject) |
ohhh gotcha |
See
https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-startup-probes
This enables apps with long startups to not be killed prematurely.
@samvera/hyrax-code-reviewers