Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chart: add support for startupProbe #6741

Closed
wants to merge 1 commit into from
Closed

Conversation

dunn
Copy link
Contributor

@dunn dunn commented Mar 18, 2024

See
https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-startup-probes

This enables apps with long startups to not be killed prematurely.

@samvera/hyrax-code-reviewers

Copy link
Contributor

@no-reply no-reply left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great.

no idea why CI is failing, but it's clearly not related

@dunn
Copy link
Contributor Author

dunn commented Mar 18, 2024

yeah, weird

Error: error resolving source context: reference not found
Usage:
  executor [flags]
  executor [command]

@dunn
Copy link
Contributor Author

dunn commented Mar 19, 2024

maybe a CI cache issue?

@dlpierce
Copy link
Contributor

I wonder if this is caused by the slash in the branch name on Circle (pull/6741) being misinterpreted by kaniko?

@dunn
Copy link
Contributor Author

dunn commented Mar 20, 2024

oh that could be; why would that suddenly be a problem, though?

@no-reply
Copy link
Contributor

no-reply commented Mar 26, 2024

@dunn can you resubmit this as a PR from samvera/hyrax instead of your fork?


i think this isn't suddenly an issue, but a general issue with PRs from forks (which i actually think it's reasonable for our build pipelines to reject)

@dunn
Copy link
Contributor Author

dunn commented Mar 26, 2024

ohhh gotcha

@dunn dunn closed this Mar 26, 2024
@dunn dunn deleted the chart-startup branch March 26, 2024 20:28
@dunn
Copy link
Contributor Author

dunn commented Mar 26, 2024

#6750

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants