avoid n+1 query on file_metadata delete #6747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyrax should avoid looping over ids when it could use a custom query. e.g. we should never be doing `my_resource.member_ids.each` and looking up members instead doing `query_service.find_members(resource: my_resource)`. doing this creates two problems: - it prevents adapters from optimizing n+1 query problems for large sets of ids. - it locks hyrax into modelling details (relationship directionality) that applications may want to avoid. there are probably other places this problem exists, but i'm aware of this one and wanted to get a patch in right away. note that this proposes unceremoniously removing the `property:` step argument. if we need to keep this, we could choose to make in `nil` by default and fall back to the old code if a value is provided. i can't see any reason a caller would want to change the property of this step though, and i strongly doubt anyone downstream is doing so.
dlpierce
approved these changes
Mar 26, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hyrax should avoid looping over ids when it could use a custom query. e.g. we should never be doing
my_resource.member_ids.eachand looking up members instead doingquery_service.find_members(resource: my_resource). doing this creates two problems:there are probably other places this problem exists, but i'm aware of this one and wanted to get a patch in right away.
@samvera/hyrax-code-reviewers