Skip to content

Examples: replaced hardcoded value #358

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Chornomorets
Copy link

  • replaced hardcoded value with existed variable that contains same value;

- replaced hardcoded value with existed variable that contains same value;
@dhorner
Copy link

dhorner commented Jul 2, 2020

The reason why it was Hardcoded is that it is a check to see if it was a Broadcast message (0xFF). If you changed the destination to another address (other than broadcast) then the change breaks it the code.

It would be better to add:

#define BROADCAST_ADDRESS 0xFF
and use that in the code instead of destination.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants