Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

homebrew options for ffmpeg in readme deprecated #26

Closed
gennaios opened this issue Feb 24, 2019 · 10 comments
Closed

homebrew options for ffmpeg in readme deprecated #26

gennaios opened this issue Feb 24, 2019 · 10 comments

Comments

@gennaios
Copy link

Hello,

Many of the options for ffmpeg install via homebrew have been removed, such as --with-fdk-aac.

Homebrew/homebrew-core#36938

As such, with a default install, I get the message:

Your ffmpeg version cannot produce top quality aac using encoder aac instead of libfdk_aac

@gennaios gennaios changed the title homebrew options in readme deprecated homebrew options for ffmpeg in readme deprecated Feb 24, 2019
@kpumuk
Copy link
Contributor

kpumuk commented Feb 24, 2019

A very sad decision from homebrew team. The easiest option now is to use a fork with brew options https://github.com/varenc/homebrew-ffmpeg

@sandreas
Copy link
Owner

I'll take a look into this in the next days. Thanks for reporting...

@gennaios
Copy link
Author

Thank you. I tried that fork a few days ago but am trying again now. I think the only options available with it are --with-chromaprint and --with-fdk-aac. I'm trying --HEAD to see mainly to figure out how to properly get --no-conversion to work.

@kpumuk
Copy link
Contributor

kpumuk commented Feb 25, 2019

brew tap varenc/ffmpeg
brew tap-pin varenc/ffmpeg
brew uninstall ffmpeg
brew install --with-chromaprint --with-fdk-aac

The rest of options are enabled by default now.

@gennaios
Copy link
Author

Those are the options I used. Thank you.

@sandreas
Copy link
Owner

Man, this was tough... i did not manage to find an easy solution for this, so i had to update the documentation with more commands i'd like to.

It seems that there is or once was a formula of m4b-tool in the core brew repo, which confused my brew installation and he always tried to install v.0.3.1, which is not the latest one and crashed with wrong checksums... very strange.

Furthermore, there is no handy command to install ffmpeg with libfdk besides the varenc repo. I hope i did not miss something, but if someone knows a better / shorter approach, i would appreciate it.

@kpumuk
Copy link
Contributor

kpumuk commented Feb 27, 2019

Looks good to me. FYI, I have noticed that m4b-tool when using ffmpeg without fdk-aac (yeah, that message about missing lib is really hard to notice, and homebrew silently dropped options, so it installed vanilla ffmpeg instead of pre-configured version), all m4b parts were converted correctly, but then it failed to merge them (e.g. the result was 5kb file without any sound).

Should it, maybe, fail by default without fdk-aac, and add a param like --ignore-missing-fdk-aac for those who are willingly trying to screw themselves?

@sandreas
Copy link
Owner

sandreas commented Feb 27, 2019

all m4b parts were converted correctly, but then it failed to merge them (e.g. the result was 5kb file without any sound).

@kpumuk
Would you mind adding an extra issue for this? I need the exact circumstances, command line params and error messages, so that i can reproduce and fix the issue...

@gennaios
Copy link
Author

gennaios commented Dec 6, 2019

Hello,

Looks like the tap mentioned in the README is no longer maintained. The new repo is

https://github.com/homebrew-ffmpeg/homebrew-ffmpeg

@sandreas sandreas reopened this Dec 6, 2019
@sandreas
Copy link
Owner

sandreas commented Dec 6, 2019

Ok, I'll take a look in the next days.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants