Template update #102
Merged
Template update #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on. e,g. Removing input fasta code and replacing with input yaml.
… into template_update
…ds the same check, this fix also optimises this check for both sub-workflows closes #96
…put into respective folders to make downstream ingestion easier
DLBPointon
requested review from
priyanka-surana
and removed request for
priyanka-surana
|
|
priyanka-surana
suggested changes
Jun 22, 2023
There was a problem hiding this comment.
Once you get the tests working, a couple other things left to get the PR merge ready.
docs/usage.md- linting errors
- Remove/replace
enable_conda- this should have been automatically addressed in the template update as well. - There is a view statement somewhere
I am not sure why the update was not correctly cascaded to all files. I am noticing a lot of my comments are around this.
… into template_update
|
|
priyanka-surana
approved these changes
Jun 23, 2023
|
I will do another full review and create tickets for any left over issues. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completing the coding for TreeVal Dev Phase 2