Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Dp24 new dev #346

Merged
merged 19 commits into from
Dec 19, 2024
Merged

Dp24 new dev #346

merged 19 commits into from
Dec 19, 2024

Conversation

DLBPointon
Copy link
Contributor

@DLBPointon DLBPointon commented Dec 10, 2024

Because we reverted steps from main and didn't propagate that change down, I have to re-add everything here.

Main has been merged into a copy of the geneset and now we merge this into dev

@DLBPointon DLBPointon self-assigned this Dec 10, 2024
Copy link

github-actions bot commented Dec 10, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit c98db8d

+| ✅ 127 tests passed       |+
#| ❔  20 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: '1.2.0'
  • pipeline_todos - TODO string in methods_description_template.yml: ## Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release
  • system_exit - System.exit in WorkflowTreeval.groovy: System.exit(1) [line 17]

❔ Tests ignored:

  • files_exist - File is ignored: assets/nf-core-treeval_logo_light.png
  • files_exist - File is ignored: conf/test_full.config
  • files_exist - File is ignored: docs/images/nf-core-treeval_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-treeval_logo_dark.png
  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-treeval_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-treeval_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-treeval_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/treeval/treeval/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2024-12-12 10:57:20

@DLBPointon
Copy link
Contributor Author

Fixed testing,
The issue was singularity running in ubuntu 24.04, however it looks like Nextflow downloading the containers is perhaps a bit smarter now so we can take back all the changes I made.

@weaglesBio Lets Merge!

@weaglesBio
Copy link
Contributor

This version has the JBrowse only entry removed, is this deliberate?

@weaglesBio weaglesBio merged commit f551ab8 into dev Dec 19, 2024
6 checks passed
@weaglesBio weaglesBio deleted the dp24_new_dev branch December 19, 2024 09:38
@DLBPointon DLBPointon restored the dp24_new_dev branch January 8, 2025 15:22
@DLBPointon DLBPointon deleted the dp24_new_dev branch January 28, 2025 15:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants