Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Hap #68

Merged
merged 13 commits into from
Feb 9, 2023
Merged

Hap #68

merged 13 commits into from
Feb 9, 2023

Conversation

yumisims
Copy link
Contributor

@yumisims yumisims commented Feb 8, 2023

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/treeval branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

deleted spaces
added spacing in the maps
tidy up and styling
@yumisims yumisims requested a review from muffato February 8, 2023 13:06
@muffato
Copy link
Member

muffato commented Feb 8, 2023

Hi Yumi. Which profile can I use to test this ?

@yumisims
Copy link
Contributor Author

yumisims commented Feb 8, 2023

@yumisims
Copy link
Contributor Author

yumisims commented Feb 8, 2023

have done all required changes

Copy link
Member

@muffato muffato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(just pushed two commits directly to fix the alignment (I got the amount of whitespace wrong) and apply prettier to modules.json)

Looks good to me !

@DLBPointon DLBPointon merged commit 80e056d into dev Feb 9, 2023
@muffato muffato deleted the hap branch February 9, 2023 13:07
DLBPointon added a commit that referenced this pull request Sep 7, 2023
Merging hap - Completes Phase 1.5 and #52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants