Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix-#1851: correct step name #1852

Merged
merged 4 commits into from
Jun 28, 2020
Merged

fix-#1851: correct step name #1852

merged 4 commits into from
Jun 28, 2020

Conversation

DavidBord
Copy link
Contributor

Fixes #1851

@ashleysommer
Copy link
Member

I noticed this discrepancy in Travis a few days ago. Thanks for fixing.

ashleysommer
ashleysommer previously approved these changes May 14, 2020
.travis.yml Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 6, 2020

Codecov Report

Merging #1852 into master will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1852      +/-   ##
==========================================
- Coverage   91.63%   91.53%   -0.10%     
==========================================
  Files          27       27              
  Lines        3000     3000              
  Branches      545      545              
==========================================
- Hits         2749     2746       -3     
- Misses        172      174       +2     
- Partials       79       80       +1     
Impacted Files Coverage Δ
sanic/server.py 73.66% <0.00%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf9ccda...e21f118. Read the comment docs.

@ahopkins ahopkins merged commit 83511a0 into sanic-org:master Jun 28, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test name against nightly without extensions is incorrect
4 participants