Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(deps): upgrade dependency react-focus-lock to v2.13.5 #8081

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Dec 16, 2024

Description

Upgrades react-focus-lock to the latest version, bringing partial React 19 support.

What to review

Focus locking still works as before. Affected areas:

/components/popoverDialog/PopoverDialog.tsx
/form/inputs/PortableText/object/modals/PopoverModal.tsx
/form/studio/tree-editing/components/breadcrumbs/TreeEditingBreadcrumbsMenuButton.tsx
/scheduledPublishing/components/dateInputs/base/DateTimeInput.tsx
/studio/components/navbar/navDrawer/NavDrawer.tsx
/studio/components/navbar/new-document/NewDocumentButton.tsx
/studio/components/navbar/search/components/filters/common/FilterPopoverWrapper.tsx
/studio/components/navbar/search/components/filters/filter/FilterForm.tsx
/studio/components/navbar/search/components/SearchPopover.tsx
/studio/components/navbar/search/SearchDialog.tsx
/tasks/components/form/fields/DateEditFormField.tsx
/ui-components/inputs/DateInputs/DateTimeInput.tsx

Testing

Relying on existing tests

Notes for release

None

@rexxars rexxars requested review from a team and RitaDias December 16, 2024 21:53
@rexxars rexxars requested a review from a team as a code owner December 16, 2024 21:53
Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 5:33pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 5:33pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 5:33pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 5:33pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 5:33pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Dec 16, 2024

Component Testing Report Updated Dec 17, 2024 5:30 PM (UTC)

❌ Failed Tests (2) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 11s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 41s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 57s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 16s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 14s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 51s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ❌ Failed (Inspect) 2m 28s 17 0 1
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 2m 33s 20 0 1
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Dec 16, 2024

⚡️ Editor Performance Report

Updated Tue, 17 Dec 2024 17:30:18 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
recipe (name) 52.6 efps (19ms) 55.6 efps (18ms) -1ms (-5.3%)
recipe (description) 58.8 efps (17ms) 58.8 efps (17ms) +0ms (-/-%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 19.2 efps (52ms) 19.4 efps (52ms) -1ms (-1.0%)
synthetic (string inside object) 20.2 efps (50ms) 19.2 efps (52ms) +3ms (+5.1%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
recipe (name) 19ms 20ms 28ms 40ms 0ms 6.9s
recipe (description) 17ms 19ms 21ms 48ms 0ms 4.5s
recipe (instructions) 5ms 7ms 10ms 23ms 0ms 3.1s
synthetic (title) 52ms 54ms 60ms 335ms 555ms 13.6s
synthetic (string inside object) 50ms 54ms 62ms 293ms 514ms 8.8s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
recipe (name) 18ms 19ms 21ms 43ms 0ms 6.8s
recipe (description) 17ms 19ms 20ms 27ms 0ms 4.4s
recipe (instructions) 5ms 7ms 8ms 18ms 0ms 3.0s
synthetic (title) 52ms 53ms 66ms 305ms 606ms 13.2s
synthetic (string inside object) 52ms 58ms 76ms 224ms 798ms 8.5s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

stipsan
stipsan previously approved these changes Dec 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants