Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(releases): hiding calendar on release picker dialog when not scheduled release type #8137

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

jordanl17
Copy link
Member

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 4:27pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 4:27pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 4:27pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 4:27pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Dec 24, 2024 4:27pm

@jordanl17 jordanl17 force-pushed the fix-corel-picker-calendar branch from 100d647 to 285af75 Compare December 24, 2024 15:55
Copy link
Contributor

No changes to documentation

@jordanl17 jordanl17 marked this pull request as ready for review December 24, 2024 16:04
@jordanl17 jordanl17 requested a review from a team as a code owner December 24, 2024 16:04
@jordanl17 jordanl17 requested review from ryanbonial, a team and ricokahler and removed request for a team, ryanbonial and ricokahler December 24, 2024 16:04
Copy link
Contributor

github-actions bot commented Dec 24, 2024

Component Testing Report Updated Dec 24, 2024 4:06 PM (UTC)

❌ Failed Tests (2) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 5s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 38s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 28s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 40s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 3m 3s 19 0 2
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Dec 24, 2024

⚡️ Editor Performance Report

Updated Tue, 24 Dec 2024 16:07:42 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 27.8 efps (36ms) 20.4 efps (49ms) +13ms (+36.1%) 🔴
article (body) 71.9 efps (14ms) 81.3 efps (12ms) -2ms (-/-%)
article (string inside object) 28.6 efps (35ms) 20.8 efps (48ms) +13ms (+37.1%) 🔴
article (string inside array) 27.0 efps (37ms) 19.2 efps (52ms) +15ms (+40.5%) 🔴
recipe (name) 55.6 efps (18ms) 30.3 efps (33ms) +15ms (+83.3%) 🔴
recipe (description) 58.8 efps (17ms) 35.7 efps (28ms) +11ms (+64.7%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) -1ms (-/-%)
synthetic (title) 18.2 efps (55ms) 7.5 efps (134ms) +79ms (+142.7%) 🔴
synthetic (string inside object) 19.0 efps (53ms) 7.8 efps (128ms) +76ms (+143.8%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 36ms 42ms 46ms 81ms 197ms 11.2s
article (body) 14ms 16ms 20ms 91ms 187ms 4.9s
article (string inside object) 35ms 37ms 44ms 188ms 152ms 6.6s
article (string inside array) 37ms 38ms 40ms 139ms 10ms 6.4s
recipe (name) 18ms 20ms 21ms 34ms 0ms 7.7s
recipe (description) 17ms 19ms 21ms 42ms 0ms 4.7s
recipe (instructions) 6ms 8ms 10ms 11ms 0ms 3.4s
synthetic (title) 55ms 57ms 64ms 327ms 676ms 14.3s
synthetic (string inside object) 53ms 54ms 63ms 389ms 221ms 8.2s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 49ms 59ms 76ms 447ms 644ms 12.7s
article (body) 12ms 15ms 18ms 121ms 89ms 4.7s
article (string inside object) 48ms 51ms 61ms 178ms 527ms 8.0s
article (string inside array) 52ms 55ms 61ms 218ms 636ms 8.1s
recipe (name) 33ms 36ms 40ms 88ms 0ms 9.9s
recipe (description) 28ms 30ms 31ms 74ms 1ms 5.6s
recipe (instructions) 6ms 7ms 8ms 22ms 0ms 3.1s
synthetic (title) 134ms 146ms 162ms 804ms 7175ms 22.1s
synthetic (string inside object) 128ms 135ms 149ms 587ms 6244ms 16.1s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant