Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(releases): remounting the title/description form for release when release being shown changes #8138

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

jordanl17
Copy link
Member

@jordanl17 jordanl17 commented Dec 24, 2024

Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 4:50pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 4:50pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 4:50pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 4:50pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Dec 24, 2024 4:50pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Dec 24, 2024

Component Testing Report Updated Dec 24, 2024 4:44 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 5s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 40s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 29s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 39s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 44s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Dec 24, 2024

⚡️ Editor Performance Report

Updated Tue, 24 Dec 2024 16:47:21 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 25.3 efps (40ms) 18.3 efps (55ms) +15ms (+38.0%) 🔴
article (body) 67.6 efps (15ms) 77.2 efps (13ms) -2ms (-/-%)
article (string inside object) 26.3 efps (38ms) 19.2 efps (52ms) +14ms (+36.8%) 🔴
article (string inside array) 23.8 efps (42ms) 18.5 efps (54ms) +12ms (+28.6%) 🔴
recipe (name) 55.6 efps (18ms) 34.5 efps (29ms) +11ms (+61.1%) 🔴
recipe (description) 64.5 efps (16ms) 37.0 efps (27ms) +12ms (+74.2%) 🔴
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 19.2 efps (52ms) 7.7 efps (130ms) +78ms (+150.0%) 🔴
synthetic (string inside object) 18.5 efps (54ms) 8.2 efps (123ms) +69ms (+126.9%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 40ms 58ms 72ms 591ms 1084ms 11.4s
article (body) 15ms 18ms 21ms 265ms 373ms 5.5s
article (string inside object) 38ms 41ms 52ms 243ms 233ms 6.8s
article (string inside array) 42ms 46ms 52ms 77ms 132ms 7.0s
recipe (name) 18ms 19ms 22ms 39ms 0ms 6.6s
recipe (description) 16ms 17ms 18ms 22ms 0ms 4.3s
recipe (instructions) 5ms 6ms 8ms 28ms 0ms 3.0s
synthetic (title) 52ms 53ms 58ms 314ms 534ms 12.8s
synthetic (string inside object) 54ms 56ms 68ms 398ms 840ms 8.4s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 55ms 71ms 97ms 422ms 1171ms 12.4s
article (body) 13ms 15ms 19ms 40ms 115ms 4.8s
article (string inside object) 52ms 58ms 63ms 235ms 716ms 8.4s
article (string inside array) 54ms 58ms 62ms 352ms 1016ms 8.6s
recipe (name) 29ms 31ms 36ms 44ms 0ms 8.3s
recipe (description) 27ms 29ms 31ms 55ms 0ms 5.5s
recipe (instructions) 5ms 6ms 7ms 27ms 0ms 3.0s
synthetic (title) 130ms 141ms 171ms 306ms 5945ms 20.0s
synthetic (string inside object) 123ms 131ms 137ms 360ms 5095ms 14.9s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@jordanl17 jordanl17 changed the title fix(releases): remounting the title/description form for release when… fix(releases): remounting the title/description form for release when release being shown changes Dec 24, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant