chore: merge next into corel #8139

jordanl17 · 2024-12-24T16:35:06Z

Description

What to review

Testing

Notes for release

vercel · 2024-12-24T16:35:10Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 25, 2024 2:09am
performance-studio	✅ Ready (Inspect)	Visit Preview		Dec 25, 2024 2:09am
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 25, 2024 2:09am
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 25, 2024 2:09am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Dec 25, 2024 2:09am

socket-security · 2024-12-24T16:36:36Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@portabletext/editor@1.18.5	None	`+7`	10.4 MB	bjoerge, kmelve, mariuslundgard, ...6 more
npm/@sanity/color-input@4.0.3	Transitive: environment, eval	`+9`	8.39 MB	sanity-io
npm/@sanity/insert-menu@1.0.18	Transitive: environment	`+2`	7.6 MB	sanity-io
npm/@sanity/react-loader@1.10.31	Transitive: network	`+4`	4.36 MB	armandocerna, ash, atombender, ...62 more
npm/@sanity/template-validator@1.2.1	network Transitive: environment, filesystem, shell, unsafe	`+24`	13 MB	sanity-io
npm/@sanity/visual-editing@2.11.3	Transitive: eval, network	`+7`	14.6 MB	sanity-io
npm/@types/react@18.3.18	None	`+1`	447 kB	types
npm/next@14.2.21	environment, filesystem, network, shell, unsafe	`+8`	88 MB	vercel-release-bot

🚮 Removed packages: npm/@codemirror/view@6.36.0, npm/@portabletext/editor@1.16.4, npm/@sanity/color-input@4.0.2, npm/@sanity/diff-match-patch@3.1.1, npm/@sanity/export@3.41.1, npm/@sanity/icons@3.5.5, npm/@sanity/react-loader@1.10.30, npm/@sanity/template-validator@1.0.3, npm/@sanity/visual-editing@2.10.10, npm/@types/react@18.3.17, npm/next@14.2.20, npm/silver-fleece@1.1.0

View full report↗︎

socket-security · 2024-12-24T16:36:40Z

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source	CI
License Policy Violation	npm/next@15.1.2	License: CC-BY-SA-4.0 - Not allowed by license policy (package/dist/compiled/glob/LICENSE, package/dist/compiled/glob/LICENSE)	Source	⚠︎
License Policy Violation	npm/next@14.2.21	License: CC-BY-SA-4.0 - Not allowed by license policy (package/dist/compiled/glob/LICENSE, package/dist/compiled/glob/LICENSE)	`dev/starter-next-studio/package.json` `pnpm-lock.yaml`	⚠︎

View full report↗︎

Next steps

What is a license policy violation?

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@SocketSecurity ignore npm/next@15.1.2
@SocketSecurity ignore npm/next@14.2.21

github-actions · 2024-12-24T16:47:50Z

No changes to documentation

github-actions · 2024-12-24T16:53:59Z

Component Testing Report Updated Dec 27, 2024 2:55 PM (UTC)

✅ All Tests Passed -- expand for details

File	Status	Duration	Passed	Skipped
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	1m 4s	15	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	13s	3	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	39s	6	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	52s	11	7
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	26s	6	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	14s	3	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	27s	6	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	1m 8s	15	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 28s	21	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 40s	18	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	13s	3	9
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	26s	6	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	1m 43s	21	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3

github-actions · 2024-12-24T16:55:25Z

⚡️ Editor Performance Report

Updated Fri, 27 Dec 2024 14:58:00 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	26.3 efps (38ms)	20.6 efps (49ms)	+11ms (+27.6%)	🔴
article (body)	77.8 efps (13ms)	72.7 efps (14ms)	+1ms (-/-%)	✅
article (string inside object)	28.6 efps (35ms)	21.3 efps (47ms)	+12ms (+34.3%)	🔴
article (string inside array)	26.0 efps (39ms)	19.2 efps (52ms)	+14ms (+35.1%)	🔴
recipe (name)	54.1 efps (19ms)	28.6 efps (35ms)	+17ms (+89.2%)	🔴
recipe (description)	66.7 efps (15ms)	30.3 efps (33ms)	+18ms (+120.0%)	🔴
recipe (instructions)	99.9+ efps (6ms)	99.9+ efps (5ms)	-1ms (-/-%)	✅
synthetic (title)	18.9 efps (53ms)	8.1 efps (123ms)	+70ms (+132.1%)	🔴
synthetic (string inside object)	20.0 efps (50ms)	7.9 efps (127ms)	+77ms (+154.0%)	🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	38ms	42ms	51ms	476ms	201ms	10.1s
article (body)	13ms	15ms	17ms	63ms	191ms	4.7s
article (string inside object)	35ms	39ms	42ms	266ms	281ms	6.6s
article (string inside array)	39ms	40ms	44ms	153ms	139ms	6.6s
recipe (name)	19ms	20ms	22ms	57ms	0ms	6.8s
recipe (description)	15ms	18ms	21ms	33ms	0ms	4.3s
recipe (instructions)	6ms	8ms	9ms	22ms	0ms	3.3s
synthetic (title)	53ms	56ms	62ms	290ms	567ms	13.1s
synthetic (string inside object)	50ms	53ms	60ms	565ms	910ms	8.2s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	49ms	54ms	64ms	208ms	1059ms	11.2s
article (body)	14ms	16ms	18ms	174ms	216ms	4.9s
article (string inside object)	47ms	51ms	58ms	242ms	433ms	8.1s
article (string inside array)	52ms	57ms	70ms	218ms	718ms	8.3s
recipe (name)	35ms	39ms	52ms	87ms	38ms	8.9s
recipe (description)	33ms	34ms	38ms	127ms	1ms	6.2s
recipe (instructions)	5ms	6ms	7ms	18ms	0ms	3.0s
synthetic (title)	123ms	132ms	147ms	367ms	6133ms	20.3s
synthetic (string inside object)	127ms	138ms	143ms	505ms	5339ms	14.5s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

vercel bot deployed to Preview – performance-studio December 24, 2024 16:49 View deployment

vercel bot deployed to Preview – page-building-studio December 24, 2024 16:50 View deployment

vercel bot deployed to Preview – test-studio December 24, 2024 16:50 View deployment

vercel bot deployed to Preview – test-next-studio December 24, 2024 16:58 View deployment

jordanl17 force-pushed the corel-next-merge-dec-24 branch from d755e23 to 976a688 Compare December 24, 2024 16:59

vercel bot deployed to Preview – page-building-studio December 24, 2024 17:05 View deployment

vercel bot deployed to Preview – performance-studio December 24, 2024 17:05 View deployment

vercel bot deployed to Preview – test-studio December 24, 2024 17:06 View deployment

vercel bot deployed to Preview – page-building-studio December 24, 2024 17:15 View deployment

vercel bot deployed to Preview – performance-studio December 24, 2024 17:15 View deployment

vercel bot deployed to Preview – test-studio December 24, 2024 17:16 View deployment

vercel bot deployed to Preview – test-next-studio December 24, 2024 17:31 View deployment

jordanl17 added 3 commits December 25, 2024 01:54

chore: merge next into corel

bf4a4a6

chore: resolving pnpm lock mismatch

d110e4f

chore: resolving ref current issue with react compiler

068e934

jordanl17 force-pushed the corel-next-merge-dec-24 branch from 50a8026 to 068e934 Compare December 25, 2024 01:54

vercel bot deployed to Preview – page-building-studio December 25, 2024 02:01 View deployment

vercel bot deployed to Preview – performance-studio December 25, 2024 02:02 View deployment

vercel bot deployed to Preview – test-studio December 25, 2024 02:02 View deployment

vercel bot deployed to Preview – test-next-studio December 25, 2024 02:09 View deployment

jordanl17 closed this Dec 27, 2024

jordanl17 reopened this Dec 27, 2024

jordanl17 marked this pull request as ready for review December 27, 2024 14:49

jordanl17 requested a review from a team as a code owner December 27, 2024 14:49

jordanl17 requested review from cngonzalez and removed request for a team and cngonzalez December 27, 2024 14:49

jordanl17 merged commit c4c664f into corel Dec 27, 2024
95 of 100 checks passed

jordanl17 deleted the corel-next-merge-dec-24 branch December 27, 2024 15:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: merge next into corel #8139

chore: merge next into corel #8139

jordanl17 commented Dec 24, 2024

vercel bot commented Dec 24, 2024 •

edited

Loading

socket-security bot commented Dec 24, 2024 •

edited

Loading

socket-security bot commented Dec 24, 2024 •

edited

Loading

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024 •

edited

Loading

github-actions bot commented Dec 24, 2024 •

edited

Loading

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

chore: merge next into corel #8139

chore: merge next into corel #8139

Conversation

jordanl17 commented Dec 24, 2024

Description

What to review

Testing

Notes for release

vercel bot commented Dec 24, 2024 • edited Loading

socket-security bot commented Dec 24, 2024 • edited Loading

socket-security bot commented Dec 24, 2024 • edited Loading

Next steps

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024 • edited Loading

github-actions bot commented Dec 24, 2024 • edited Loading

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

vercel bot commented Dec 24, 2024 •

edited

Loading

socket-security bot commented Dec 24, 2024 •

edited

Loading

socket-security bot commented Dec 24, 2024 •

edited

Loading

github-actions bot commented Dec 24, 2024 •

edited

Loading

github-actions bot commented Dec 24, 2024 •

edited

Loading