Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: releasesOverview into utils and smaller components for calendar filter #8144

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

jordanl17
Copy link
Member

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 4:35pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 4:35pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 4:35pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 4:35pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Dec 27, 2024 4:35pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Dec 27, 2024 4:33 PM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 5s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 19s 5 0 1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 28s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 40s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 44s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Fri, 27 Dec 2024 16:35:15 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 24.1 efps (42ms) 16.5 efps (61ms) +19ms (+45.8%) 🔴
article (body) 63.3 efps (16ms) 63.3 efps (16ms) +0ms (-/-%)
article (string inside object) 27.8 efps (36ms) 18.5 efps (54ms) +18ms (+50.0%) 🔴
article (string inside array) 24.7 efps (41ms) 16.5 efps (61ms) +20ms (+49.4%) 🔴
recipe (name) 52.6 efps (19ms) 32.3 efps (31ms) +12ms (+63.2%) 🔴
recipe (description) 55.6 efps (18ms) 34.5 efps (29ms) +11ms (+61.1%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) -1ms (-/-%)
synthetic (title) 19.2 efps (52ms) 8.1 efps (124ms) +72ms (+138.5%) 🔴
synthetic (string inside object) 19.2 efps (52ms) 8.2 efps (122ms) +70ms (+134.6%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 42ms 47ms 58ms 343ms 528ms 10.0s
article (body) 16ms 18ms 27ms 184ms 231ms 5.6s
article (string inside object) 36ms 39ms 44ms 204ms 252ms 6.6s
article (string inside array) 41ms 42ms 46ms 89ms 163ms 6.8s
recipe (name) 19ms 20ms 23ms 33ms 0ms 8.2s
recipe (description) 18ms 19ms 21ms 30ms 0ms 4.5s
recipe (instructions) 6ms 8ms 9ms 17ms 0ms 3.1s
synthetic (title) 52ms 54ms 60ms 337ms 508ms 13.0s
synthetic (string inside object) 52ms 56ms 69ms 373ms 495ms 8.3s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 61ms 72ms 109ms 568ms 1438ms 12.4s
article (body) 16ms 17ms 20ms 45ms 78ms 5.0s
article (string inside object) 54ms 57ms 65ms 148ms 688ms 8.8s
article (string inside array) 61ms 65ms 75ms 212ms 1109ms 8.8s
recipe (name) 31ms 33ms 37ms 47ms 2ms 8.0s
recipe (description) 29ms 31ms 38ms 204ms 14ms 6.1s
recipe (instructions) 6ms 7ms 8ms 27ms 0ms 3.0s
synthetic (title) 124ms 127ms 153ms 793ms 5921ms 20.3s
synthetic (string inside object) 122ms 125ms 138ms 696ms 5389ms 14.3s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@jordanl17 jordanl17 marked this pull request as ready for review December 27, 2024 16:48
@jordanl17 jordanl17 requested a review from a team as a code owner December 27, 2024 16:48
@jordanl17 jordanl17 requested review from ricokahler and removed request for a team and ricokahler December 27, 2024 16:48
@jordanl17 jordanl17 merged commit 303c3d4 into corel Dec 27, 2024
57 checks passed
@jordanl17 jordanl17 deleted the corel-refactor-releases-overview branch December 27, 2024 16:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant