Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor(core): perf work #8281

Draft
wants to merge 3 commits into
base: corel
Choose a base branch
from
Draft

refactor(core): perf work #8281

wants to merge 3 commits into from

Conversation

RitaDias
Copy link
Contributor

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 2:51pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 2:51pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 2:51pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 2:51pm
test-next-studio ⬜️ Ignored (Inspect) Jan 15, 2025 2:51pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Jan 15, 2025

Component Testing Report Updated Jan 15, 2025 2:55 PM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 5s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 19s 5 0 1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 26s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 37s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 12s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 25s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 41s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Jan 15, 2025

⚡️ Editor Performance Report

Updated Wed, 15 Jan 2025 14:56:36 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 24.7 efps (41ms) 27.0 efps (37ms) -4ms (-8.6%)
article (body) 63.5 efps (16ms) 63.3 efps (16ms) +0ms (-/-%)
article (string inside object) 27.4 efps (37ms) 28.6 efps (35ms) -2ms (-4.1%)
article (string inside array) 23.8 efps (42ms) 25.0 efps (40ms) -2ms (-4.8%)
recipe (name) 50.0 efps (20ms) 54.1 efps (19ms) -2ms (-7.5%)
recipe (description) 58.8 efps (17ms) 62.5 efps (16ms) -1ms (-5.9%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 19.0 efps (53ms) 20.8 efps (48ms) -5ms (-8.6%)
synthetic (string inside object) 20.0 efps (50ms) 20.8 efps (48ms) -2ms (-4.0%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 50ms 68ms 405ms 614ms 11.4s
article (body) 16ms 18ms 21ms 48ms 97ms 5.2s
article (string inside object) 37ms 39ms 45ms 83ms 120ms 6.5s
article (string inside array) 42ms 43ms 47ms 59ms 137ms 6.8s
recipe (name) 20ms 22ms 31ms 42ms 1ms 6.8s
recipe (description) 17ms 18ms 19ms 32ms 0ms 4.3s
recipe (instructions) 6ms 8ms 10ms 34ms 0ms 3.3s
synthetic (title) 53ms 55ms 59ms 324ms 607ms 12.3s
synthetic (string inside object) 50ms 52ms 58ms 276ms 623ms 8.2s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 37ms 46ms 66ms 376ms 870ms 10.8s
article (body) 16ms 18ms 28ms 89ms 230ms 5.4s
article (string inside object) 35ms 41ms 48ms 107ms 198ms 7.3s
article (string inside array) 40ms 42ms 47ms 147ms 146ms 7.1s
recipe (name) 19ms 20ms 25ms 40ms 0ms 7.1s
recipe (description) 16ms 17ms 20ms 32ms 0ms 4.6s
recipe (instructions) 6ms 7ms 8ms 9ms 0ms 3.1s
synthetic (title) 48ms 50ms 61ms 141ms 257ms 11.6s
synthetic (string inside object) 48ms 54ms 61ms 522ms 998ms 8.6s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant