Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(core): cannot find namespace 'vi' #8282

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

pedrobonamin
Copy link
Contributor

Description

Fixes a type import issue in where using vi.<Type> would give the following error:

Cannot find namespace 'vi'

What to review

Is the change correct?

Testing

It's only a type definition change, existing tests cover this.

Notes for release

n/a, internal only

@pedrobonamin pedrobonamin requested a review from a team as a code owner January 15, 2025 15:28
@pedrobonamin pedrobonamin requested review from bjoerge and removed request for a team January 15, 2025 15:28
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 3:34pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 3:34pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 3:34pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jan 15, 2025 3:34pm
test-next-studio ⬜️ Ignored (Inspect) Jan 15, 2025 3:34pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Jan 15, 2025 3:38 PM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 3s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 18s 5 0 1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 25s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 6s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 27s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 39s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 12s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 42s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Wed, 15 Jan 2025 15:40:56 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 23.3 efps (43ms) 22.2 efps (45ms) +2ms (+4.7%)
article (body) 53.8 efps (19ms) 61.5 efps (16ms) -2ms (-12.6%)
article (string inside object) 24.7 efps (41ms) 23.5 efps (43ms) +2ms (+4.9%)
article (string inside array) 21.1 efps (48ms) 21.3 efps (47ms) -1ms (-1.1%)
recipe (name) 47.6 efps (21ms) 47.6 efps (21ms) +0ms (-/-%)
recipe (description) 54.1 efps (19ms) 55.6 efps (18ms) -1ms (-2.7%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (6ms) +1ms (-/-%)
synthetic (title) 19.2 efps (52ms) 18.9 efps (53ms) +1ms (+1.9%)
synthetic (string inside object) 18.5 efps (54ms) 20.0 efps (50ms) -4ms (-7.4%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 43ms 52ms 68ms 423ms 842ms 11.2s
article (body) 19ms 21ms 35ms 223ms 295ms 6.1s
article (string inside object) 41ms 43ms 48ms 169ms 149ms 7.0s
article (string inside array) 48ms 51ms 54ms 158ms 407ms 7.7s
recipe (name) 21ms 23ms 24ms 32ms 0ms 7.3s
recipe (description) 19ms 20ms 24ms 39ms 0ms 4.6s
recipe (instructions) 5ms 7ms 9ms 18ms 0ms 3.1s
synthetic (title) 52ms 55ms 85ms 131ms 501ms 13.1s
synthetic (string inside object) 54ms 56ms 68ms 243ms 1532ms 9.0s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 45ms 65ms 83ms 461ms 962ms 11.7s
article (body) 16ms 19ms 27ms 35ms 254ms 5.6s
article (string inside object) 43ms 45ms 48ms 165ms 203ms 7.4s
article (string inside array) 47ms 50ms 57ms 223ms 408ms 7.6s
recipe (name) 21ms 22ms 24ms 33ms 0ms 7.1s
recipe (description) 18ms 19ms 21ms 28ms 0ms 4.5s
recipe (instructions) 6ms 7ms 8ms 18ms 0ms 3.1s
synthetic (title) 53ms 56ms 62ms 291ms 918ms 12.8s
synthetic (string inside object) 50ms 58ms 69ms 477ms 1010ms 8.1s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@pedrobonamin pedrobonamin added this pull request to the merge queue Jan 15, 2025
Merged via the queue into next with commit 3a3cc58 Jan 15, 2025
56 checks passed
@pedrobonamin pedrobonamin deleted the fix-vitest-imports branch January 15, 2025 18:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants