feat(core): update events api routes and config flags, fix events sorting #8369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
pedrobonamin
requested review from
a team and
bjoerge
and removed request for
ricokahler
|
No changes to documentation |
|
Component Testing Report Updated Jan 27, 2025 4:35 PM (UTC) ❌ Failed Tests (1) -- expand for details
|
⚡️ Editor Performance ReportUpdated Mon, 27 Jan 2025 18:44:11 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
pedrobonamin
force-pushed
the
corel-363
branch
from
83fbfeb to
d9bbcbd
Compare
pedrobonamin
force-pushed
the
corel-363
branch
from
52f12af to
985bfd1
Compare
pedrobonamin
force-pushed
the
corel-363
branch
from
985bfd1 to
a8d7760
Compare
pedrobonamin
changed the title
juice49
approved these changes
Jan 28, 2025
| // @ts-expect-error enabled is a legacy option we want to warn beta testers in case they have enabled it. | ||
| if (innerConfig.beta?.eventsAPI?.enabled) { | ||
| throw new Error( | ||
| `The \`beta.eventsAPI.enabled\` option has been removed. Use \`beta.eventsAPI.${opts.key}\` instead.`, |
There was a problem hiding this comment.
Nice to warn these folks 👍.
| expandedEvents: EditDocumentVersionEvent[] | ||
| }): DocumentGroupEvent[] { | ||
| const eventsWithRemoteEdits = [...remoteEdits, ...events, ...expandedEvents].sort( | ||
| // Sort by timestamp, newest first unless is an edit event that has a corresponding publish event |
There was a problem hiding this comment.
Good catch and nice test coverage.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the events api routes that we were using.
The routes now will be:
data/history/{datasetName}/events/documents/{ids}data/history/{datasetName}/events/releases/{id}It also modifies the config flag we have added for the events api and enables it by default for documents events for all the studios.
It's kept as a flag in case we need to turn it off.
Releases events are not ready to be used by everyone yet, so a new flag has been added to handle this. It will be enabled by default in the
playgroundstudio.It also updates the sort algorithm for the events, given the timestamp validation is not the only check necessary, because edit and publish events now have the same timestamp and the order was incorrect.
What to review
Testing
Notes for release