Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

sap_hana_install: Solve issue #788. #789

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

sap_hana_install: Solve issue #788. #789

wants to merge 1 commit into from

Conversation

berndfinger
Copy link
Member

We do not want to fail the role in task Rename some variables used by hdblcm configfile if sap_hana_install_common_master_password is not set.

@berndfinger
sap_hana_install: Solve issue sap-linuxlab#788.
fc406a4 
We do not want to fail the role in task `Rename some variables used by
hdblcm configfile` if `sap_hana_install_common_master_password` is not
set.

Signed-off-by: Bernd Finger <bfinger@redhat.com>
sean-freeman
sean-freeman approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@sean-freeman sean-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. lgtm 👍

@berndfinger
Copy link
Member Author

The proposed solution can lead to sap_hana_install_master_password being empty, which will lead to a failing SAP HANA installation. So we should better add one more check to handle this situation.

@berndfinger berndfinger marked this pull request as draft July 5, 2024 14:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sean-freeman sean-freeman sean-freeman approved these changes

@ja9fuchs ja9fuchs Awaiting requested review from ja9fuchs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berndfinger @sean-freeman