allow new log levels #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasa1977
reviewed
Jun 19, 2024
lib/site_encrypt.ex
Outdated
Comment on lines
50
to
56
| log_levels = | ||
| if Version.compare(System.version(), "1.11.0") in [:gt, :eq] do | ||
| [:error, :info, :debug, :emergency, :alert, :critical, :warning, :notice] | ||
| else | ||
| [:debug, :info, :warn, :error] | ||
| end | ||
|
|
There was a problem hiding this comment.
I don't think there's need for these version gymnastics. I propose we use Logger.levels/0, but we should then change mix.exs and require 1.16+. WDYT?
There was a problem hiding this comment.
Of course I prefer this :)
I just didn't think it was appropriate to ask for dropping support for old Elixir versions just to support my little feature request.
There was a problem hiding this comment.
I'll update the PR in the next few minutes.
|
Thank you! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
I'd like to use NOTICE log level for SiteEncrypt messages and this PR should allow that. I'm not sure when if
Logger.levels/0was available in Elixir v1.10, but I'll try to find out.Seems to be available only since v1.16.0 https://hexdocs.pm/logger/1.17.0/Logger.html#levels/0, I'll hardcode it then.
The extended log levels were made available in v1.11.0 https://hexdocs.pm/logger/1.11.0/Logger.html#module-levels