Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Should error when attempting to output an empty list or map #1452

Closed
xzyfer opened this issue Aug 17, 2015 · 3 comments
Closed

Should error when attempting to output an empty list or map #1452

xzyfer opened this issue Aug 17, 2015 · 3 comments

Comments

@xzyfer
Copy link
Contributor

xzyfer commented Aug 17, 2015

foo {
  foo: foo(());
}

Ruby Sass

Error: () isn't a valid CSS value.
        on line 57 of test.scss

Libsass

foo {
  foo: foo(); }
@KittyGiraudel
Copy link

Ruby Sass seems as wrong as LibSass to me.

@mgreter
Copy link
Contributor

mgreter commented Jan 20, 2016

This is quite a special case since this is done during Function_Call evaluation. So the List never gets to the Output visitor, which would error in that case. Not sure how to solve this, but we should probably aim to return a function call from the eval step, with evaluated arguments, so output can do it's job. Tried this and it looks promising, but there were some other regressions.

@mgreter
Copy link
Contributor

mgreter commented Jan 20, 2016

Just checked and I see I implemented that error in Output, which worked for:

$a: (());
foo {
  foo: $a;
}

But not for the originally reported case, so maybe it's worth creating two issues here ...

@mgreter mgreter modified the milestones: 3.3.5, 3.3.4 Feb 23, 2016
@mgreter mgreter modified the milestones: 3.3.6, 3.3.5 Apr 6, 2016
@mgreter mgreter modified the milestones: 3.3.7, 3.3.6 Apr 23, 2016
@mgreter mgreter modified the milestones: 3.3.8, 3.3.7 Apr 30, 2016
@xzyfer xzyfer modified the milestones: 3.3.8, 3.4 May 20, 2016
@xzyfer xzyfer modified the milestones: 3.4.1, 3.4 Sep 8, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

4 participants