Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Segfault parsing multiple operations in calc #2151

Closed
smoogly opened this issue Aug 17, 2016 · 2 comments
Closed

Segfault parsing multiple operations in calc #2151

smoogly opened this issue Aug 17, 2016 · 2 comments

Comments

@smoogly
Copy link

smoogly commented Aug 17, 2016

input.scss

div {
        $v: 1px;
        min-height: calc( #{$v} + #{$v} + #{$v} + #{$v} + #{$v} );
}

libsass 3.3.6
segmentation fault

ruby sass 3.4.21

div {
  min-height: calc( 1px + 1px + 1px + 1px + 1px );
}

version info:

node-sass   3.7.0   (Wrapper)   [JavaScript]
libsass     3.3.6   (Sass Compiler) [C/C++]

Notice following compiles properly:

div {
        $v: 1px;
        min-height: calc( #{$v} + #{$v} + #{$v} );
}
@xzyfer xzyfer added this to the 3.4 milestone Aug 23, 2016
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Aug 23, 2016
@xzyfer
Copy link
Contributor

xzyfer commented Aug 23, 2016

Simplified reproduction

$v: 1px;
$b: #{$v} + #{$v} + #{$v} + #{$v} + #{$v};

Interestingly this relies on deprecated Sass behaviour. It's possible this behaviour will be removed from Sass before it's patched in LibSass.

Spec added sass/sass-spec#893

@xzyfer xzyfer removed this from the 3.4 milestone Aug 23, 2016
mgreter added a commit to mgreter/libsass that referenced this issue Sep 2, 2016
@mgreter mgreter added this to the 3.3.7 milestone Sep 2, 2016
@mgreter mgreter self-assigned this Sep 2, 2016
@smoogly
Copy link
Author

smoogly commented Sep 2, 2016

Thanks!

@xzyfer xzyfer modified the milestones: 3.3.7, 3.4 Oct 20, 2016
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Sep 2, 2017
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Sep 4, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants