Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Empty nested media query causes remaining output in containing media query to not render #2154

Closed
stepmr opened this issue Aug 20, 2016 · 2 comments
Closed

Empty nested media query causes remaining output in containing media query to not render #2154

stepmr opened this issue Aug 20, 2016 · 2 comments
Assignees
@xzyfer
Labels
Bug - Confirmed Dev - PR Ready Dev - Test Written Sass 3.4
Milestone
3.4

Comments

@stepmr
Copy link

stepmr commented Aug 20, 2016 •
edited by HamptonMakes
Loading

Title: Empty nested media query causes remaining output in containing media query to not render

input.scss

@media (min-width: 1px) {
  .first {
    font-weight: 100;

    @media (min-width: 2px) {}
  }
  .second {
    font-weight: 200;
  }
}

libsass 3.3.6

@media (min-width: 1px) {
  .first {
    font-weight: 100;
  }
}

ruby sass 3.4.21

@media (min-width: 1px) {
  .first {
    font-weight: 100;
  }
  .second {
    font-weight: 200;
  }
}

version info:

$ node-sass --version
node-sass       3.8.0   (Wrapper)       [JavaScript]
libsass         3.3.6   (Sass Compiler) [C/C++]
@stepmr stepmr changed the title Empty nested media query causes remaining output in containing media query to not render Empty nested media query causes remaining output in containing media query to not output Aug 20, 2016
@stepmr stepmr changed the title Empty nested media query causes remaining output in containing media query to not output Empty nested media query causes remaining output in containing media query to not render Aug 20, 2016
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Aug 23, 2016
@xzyfer
Add specs for issue 2154
1343c54 
This PR add specs for sass/libsass#2154
@xzyfer xzyfer mentioned this issue Aug 23, 2016
Merged
@xzyfer
Copy link
Contributor

xzyfer commented Aug 23, 2016

I can confirm this issue. Spec added sass/sass-spec#891

@xzyfer xzyfer added this to the 3.4 milestone Aug 23, 2016
@xzyfer xzyfer self-assigned this Sep 13, 2016
@xzyfer
Copy link
Contributor

xzyfer commented Sep 13, 2016

I've started looking into this. I've confirmed it's a bug with the cssize visitor.

xzyfer added a commit to xzyfer/sass-spec that referenced this issue Sep 21, 2016
@xzyfer
Activate specs for issue 2154
3ccebcf 
This PR activates specs for sass/libsass#2154
@xzyfer xzyfer mentioned this issue Sep 21, 2016
Merged
xzyfer added a commit to xzyfer/libsass that referenced this issue Sep 21, 2016
@xzyfer
Fix bug with bubbling empty blocks
77ee4c7 
This was a casuality of me not being able to grok `unless` and how
object assignment works in Ruby.

Spec sass/sass-spec#924
Fixes sass#2154
@xzyfer xzyfer mentioned this issue Sep 21, 2016
Merged
xzyfer added a commit to xzyfer/libsass that referenced this issue Sep 21, 2016
@xzyfer
Fix bug with bubbling empty blocks
03d0d08 
This was a casuality of me not being able to grok `unless` and how
object assignment works in Ruby.

Spec sass/sass-spec#924
Fixes sass#2154
xzyfer added a commit to xzyfer/libsass that referenced this issue Sep 21, 2016
@xzyfer
Fix bug with bubbling empty blocks
a9a620a 
This was a casuality of me not being able to grok `unless` and how
object assignment works in Ruby.

Spec sass/sass-spec#924
Fixes sass#2154
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@xzyfer xzyfer

Labels
Bug - Confirmed Dev - PR Ready Dev - Test Written Sass 3.4
Projects
None yet
Milestone
3.4
Development

No branches or pull requests
2 participants
@stepmr @xzyfer