Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Regression with @extend breaks foundation #2200

Closed
xzyfer opened this issue Oct 4, 2016 · 1 comment
Closed

Regression with @extend breaks foundation #2200

xzyfer opened this issue Oct 4, 2016 · 1 comment

Comments

@xzyfer
Copy link
Contributor

xzyfer commented Oct 4, 2016

#2052 introduced a regression (d83f879) which is breaking foundation.

.media-object-section:last-child:not(:nth-child(2)) {
  color: blue;
}

%orbit-control {
  color: red;
}

.orbit-previous {
  @extend %orbit-control;
}

LibSass 3.4 RC

.media-object-section:last-child {
  color: blue; }

.orbit-previous {
  color: red; }

LibSass 3.3.6

.media-object-section:last-child:not(:nth-child(2)) {
  color: blue; }

.orbit-previous {
  color: red; }

Spec added sass/sass-spec#939

@xzyfer
Copy link
Contributor Author

xzyfer commented Oct 4, 2016

/cc @mgreter

@xzyfer xzyfer mentioned this issue Oct 8, 2016
6 tasks
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Oct 17, 2016
xzyfer added a commit to xzyfer/libsass that referenced this issue Oct 17, 2016
The extend visitor currently mutates some selectors, even ones that
get extended. This patch works around a specific use case that breaks
foundation.

Spec sass/sass-spec#949
Fixes sass#2200
xzyfer added a commit to xzyfer/libsass that referenced this issue Oct 17, 2016
The extend visitor currently mutates some selectors, even ones that
get extended. This patch works around a specific use case that breaks
foundation.

Spec sass/sass-spec#949
Fixes sass#2200
xzyfer added a commit to xzyfer/libsass that referenced this issue Oct 17, 2016
The extend visitor currently mutates some selectors, even ones that
get extended. This patch works around a specific use case that breaks
foundation.

Spec sass/sass-spec#949
Fixes sass#2200
xzyfer added a commit to xzyfer/libsass that referenced this issue Oct 18, 2016
The extend visitor currently mutates some selectors, even ones that
get extended. This patch works around a specific use case that breaks
foundation.

Spec sass/sass-spec#949
Fixes sass#2200
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant