-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Improve IE expression parsing #690
Comments
Maybe the |
@xzyfer I guess we can close this minor issue. IMO I have changed the parsing with my latest commit anyway! What do you think? I'd say let's wait if someone screams that it is really broken! |
👍 |
I have a case in which this is broken. Not completely sure is related with the same issue discussed here, but it has to do with eh IE expression. Here's the scss: @mixin spec1() {
spec1: unquote("3 + \"px\"");
}
@mixin spec2($e) {
spec2: unquote("#{$e} + \"px\"");
}
@mixin spec3($e) {
spec3: unquote("#{$e} + 'px'");
}
.element {
@include spec1;
@include spec2(3);
@include spec3(3);
} The expected result will be: .element {
spec1: 3 + "px";
spec2: 3 + "px";
spec3: 3 + 'px'; } However, libsass will output: .element {
right: 3 + "px";
right: 3 + \"px\";
right: 3 + 'px'; } I can open a new issue and create specs if you think is needed |
Please open a new issue @al3jo. |
As discussed in #685, we should enhance
expression
(ie specific) parsing , which currently parses a simple()
delimited string. This means it will fail on the following samples (not verified):@xzyfer proposed a simple parsing function which parses balanced brackets, while beeing aware of quoted strings and other escape sequences. I'm unaware how the original IE parser handles them (it's javascript!), or, what would be more important for us, how the ruby sass implementation is handling this.
The text was updated successfully, but these errors were encountered: