Improve ie property and expression parsing #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgreter
force-pushed
the
bugfix/issue_1188
branch
from
0a29296 to
60f3439
Compare
mgreter
force-pushed
the
bugfix/issue_1188
branch
2 times, most recently
from
b70825c to
eedba4d
Compare
| text += i; | ||
| } else if (!inside_str && (i == '"' || i == '\'')) { | ||
| } else if (false && !inside_str && (i == '"' || i == '\'')) { |
There was a problem hiding this comment.
Good catch, seems valid, can be gone ...
|
Spec PR sass/sass-spec#375 |
mgreter
force-pushed
the
bugfix/issue_1188
branch
from
eedba4d to
cd18ae8
Compare
|
👍 Also I wonder if parsing these ie expressions is worth the effort (and perf hit?). Could we get away with going back to treating these as |
xzyfer
added a commit
that referenced
this pull request
May 12, 2015
Improve ie property and expression parsing
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1188
Fixes #1107
Fixes #1102
Fixes #931