Fix issue with invalid duplicate keys #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mgreter. Looks good. I'll write a test and merge soon. |
Keys `1` and `1px` were considered duplicates if they end up in the same bucket. In sass these are indeed equal but that does not seem to apply when used as hash keys.
mgreter
force-pushed
the
bugfix/invalid-duplicate-map-key
branch
from
6f29dd8 to
4682c70
Compare
|
@xzyfer this is a compiler edge case and only happens if the hash table implementation puts both keys in the same bucket for some reason (it should not). This is not the case in any of libsass' CI envs. I only saw it with some compilers and perl cpan "CI" (see links above). |
|
👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keys
1and1pxwere considered duplicates if they endup in the same bucket. In sass these are indeed equal but
that does not seem to apply when used as hash keys.
@xzyfer feel free to refactor as you see fit.