Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Delay Unary_Expression according to parsed operand #2189

Merged
merged 1 commit into from
Sep 25, 2016

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented Sep 25, 2016

Fixes #2149

@mgreter mgreter self-assigned this Sep 25, 2016
@mgreter mgreter added this to the 3.3.7 milestone Sep 25, 2016
@mgreter mgreter merged commit 8cd9434 into sass:master Sep 25, 2016
xzyfer added a commit to xzyfer/libsass that referenced this pull request Sep 28, 2016
Sass spec has a bug with probe todo that causes some failures to be
hidden. As a result sass#2189 caused a regression.
@xzyfer xzyfer mentioned this pull request Sep 28, 2016
@xzyfer
Copy link
Contributor

xzyfer commented Sep 28, 2016

This caused a regression that was hidden by a bug in Sass spec - sass/sass-spec#932

@xzyfer xzyfer mentioned this pull request Sep 28, 2016
6 tasks
@mgreter
Copy link
Contributor Author

mgreter commented Sep 28, 2016

My bisect shows the regression happened much earlier in 734668f

It basically boils down that I did not anticipate the following sass behavior (3.4.22):

h1 {
  delayd: #{5% / 2};
  delayd: #{+5% / 2};
  evaled: #{-5% / 2};
}
h1 {
  delayd: 5%/2;
  delayd: 5%/2;
  evaled: -2.5%;
}

@xzyfer
Copy link
Contributor

xzyfer commented Oct 3, 2016

@mgreter do you think you'll have a chance to look into this? Otherwise I may have to back this patch out of 3.4.

@xzyfer
Copy link
Contributor

xzyfer commented Oct 3, 2016

@mgreter I talked to @nex3, she confirmed the evaled case is bug in Sass.

that's a bug, the last one should be -5%/2

xzyfer added a commit to xzyfer/libsass that referenced this pull request Oct 4, 2016
Sass spec has a bug with probe todo that causes some failures to be
hidden. As a result sass#2189 caused a regression.
xzyfer added a commit to xzyfer/libsass that referenced this pull request Oct 18, 2016
Sass spec has a bug with probe todo that causes some failures to be
hidden. As a result sass#2189 caused a regression.
@xzyfer xzyfer modified the milestones: 3.3.7, 3.4 Oct 20, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants